Messages in this thread |  | | Subject | Re: [PATCH RESEND][next] qlcnic: Fix fall-through warnings for Clang | | From | "Gustavo A. R. Silva" <> | | Date | Mon, 17 May 2021 19:25:43 -0500 |
| |
Hi,
I'm taking this in my -next[1] branch for v5.14.
Thanks -- Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
On 4/20/21 15:27, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 3/5/21 03:17, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple >> warnings by explicitly adding a break and a goto statements instead of >> just letting the code fall through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 1 + >> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c >> index bdf15d2a6431..af4c516a9e7c 100644 >> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c >> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c >> @@ -1390,6 +1390,7 @@ static int qlcnic_process_rcv_ring(struct qlcnic_host_sds_ring *sds_ring, int ma >> break; >> case QLCNIC_RESPONSE_DESC: >> qlcnic_handle_fw_message(desc_cnt, consumer, sds_ring); >> + goto skip; >> default: >> goto skip; >> } >> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c >> index 96b947fde646..8966f1bcda77 100644 >> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c >> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c >> @@ -3455,6 +3455,7 @@ qlcnic_fwinit_work(struct work_struct *work) >> adapter->fw_wait_cnt = 0; >> return; >> } >> + break; >> case QLCNIC_DEV_FAILED: >> break; >> default: >>
|  |