lkml.org 
[lkml]   [2021]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 208/329] ethtool: fix missing NLM_F_MULTI flag when dumping
    Date
    From: Fernando Fernandez Mancera <ffmancera@riseup.net>

    [ Upstream commit cf754ae331be7cc192b951756a1dd031e9ed978a ]

    When dumping the ethtool information from all the interfaces, the
    netlink reply should contain the NLM_F_MULTI flag. This flag allows
    userspace tools to identify that multiple messages are expected.

    Link: https://bugzilla.redhat.com/1953847
    Fixes: 365f9ae4ee36 ("ethtool: fix genlmsg_put() failure handling in ethnl_default_dumpit()")
    Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/ethtool/netlink.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c
    index 50d3c8896f91..25a55086d2b6 100644
    --- a/net/ethtool/netlink.c
    +++ b/net/ethtool/netlink.c
    @@ -384,7 +384,8 @@ static int ethnl_default_dump_one(struct sk_buff *skb, struct net_device *dev,
    int ret;

    ehdr = genlmsg_put(skb, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_seq,
    - &ethtool_genl_family, 0, ctx->ops->reply_cmd);
    + &ethtool_genl_family, NLM_F_MULTI,
    + ctx->ops->reply_cmd);
    if (!ehdr)
    return -EMSGSIZE;

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-17 18:01    [W:2.785 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site