lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 076/244] mtd: rawnand: fsmc: Fix error code in fsmc_nand_probe()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit e7a97528e3c787802d8c643d6ab2f428511bb047 ]

    If dma_request_channel() fails then the probe fails and it should
    return a negative error code, but currently it returns success.

    fixes: 4774fb0a48aa ("mtd: nand/fsmc: Add DMA support")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/YCqaOZ83OvPOzLwh@mwanda
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/nand/raw/fsmc_nand.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/mtd/nand/raw/fsmc_nand.c b/drivers/mtd/nand/raw/fsmc_nand.c
    index a6964feeec77..81e4b0f46662 100644
    --- a/drivers/mtd/nand/raw/fsmc_nand.c
    +++ b/drivers/mtd/nand/raw/fsmc_nand.c
    @@ -1066,11 +1066,13 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
    host->read_dma_chan = dma_request_channel(mask, filter, NULL);
    if (!host->read_dma_chan) {
    dev_err(&pdev->dev, "Unable to get read dma channel\n");
    + ret = -ENODEV;
    goto disable_clk;
    }
    host->write_dma_chan = dma_request_channel(mask, filter, NULL);
    if (!host->write_dma_chan) {
    dev_err(&pdev->dev, "Unable to get write dma channel\n");
    + ret = -ENODEV;
    goto release_dma_read_chan;
    }
    }
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 17:02    [W:2.031 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site