lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 070/244] ARM: dts: exynos: correct PMIC interrupt trigger level on SMDK5250
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit f6368c60561370e4a92fac22982a3bd656172170 ]

    The Maxim PMIC datasheets describe the interrupt line as active low
    with a requirement of acknowledge from the CPU. Without specifying the
    interrupt type in Devicetree, kernel might apply some fixed
    configuration, not necessarily working for this hardware.

    Additionally, the interrupt line is shared so using level sensitive
    interrupt is here especially important to avoid races.

    Fixes: 47580e8d94c2 ("ARM: dts: Specify MAX77686 pmic interrupt for exynos5250-smdk5250")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Link: https://lore.kernel.org/r/20201210212534.216197-8-krzk@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
    index 6dc96948a9cc..70a2b6e2ad3f 100644
    --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
    +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
    @@ -133,7 +133,7 @@
    compatible = "maxim,max77686";
    reg = <0x09>;
    interrupt-parent = <&gpx3>;
    - interrupts = <2 IRQ_TYPE_NONE>;
    + interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
    pinctrl-names = "default";
    pinctrl-0 = <&max77686_irq>;
    wakeup-source;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 16:58    [W:6.038 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site