lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] s390/vfio-ap: fix memory leak in mdev remove callback
    On Mon, 10 May 2021 17:48:37 -0400
    Tony Krowiak <akrowiak@linux.ibm.com> wrote:

    > The mdev remove callback for the vfio_ap device driver bails out with
    > -EBUSY if the mdev is in use by a KVM guest. The intended purpose was
    > to prevent the mdev from being removed while in use; however, returning a
    > non-zero rc does not prevent removal. This could result in a memory leak
    > of the resources allocated when the mdev was created. In addition, the
    > KVM guest will still have access to the AP devices assigned to the mdev
    > even though the mdev no longer exists.
    >
    > To prevent this scenario, cleanup will be done - including unplugging the
    > AP adapters, domains and control domains - regardless of whether the mdev
    > is in use by a KVM guest or not.
    >
    > Fixes: 258287c994de ("s390: vfio-ap: implement mediated device open callback")
    > Cc: stable@vger.kernel.org
    > Signed-off-by: Tony Krowiak <akrowiak@stny.rr.com>
    > ---
    > drivers/s390/crypto/vfio_ap_ops.c | 13 ++-----------
    > 1 file changed, 2 insertions(+), 11 deletions(-)

    With the S-o-b fixed,

    Reviewed-by: Cornelia Huck <cohuck@redhat.com>

    \
     
     \ /
      Last update: 2021-05-12 12:35    [W:4.099 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site