lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 27/34] nvmet: remove unsupported command noise
    Date
    From: Keith Busch <kbusch@kernel.org>

    [ Upstream commit 4a20342572f66c5b20a1ee680f5ac0a13703748f ]

    Nothing can stop a host from submitting invalid commands. The target
    just needs to respond with an appropriate status, but that's not a
    target error. Demote invalid command messages to the debug level so
    these events don't spam the kernel logs.

    Reported-by: Yi Zhang <yi.zhang@redhat.com>
    Signed-off-by: Keith Busch <kbusch@kernel.org>
    Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
    Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/nvme/target/admin-cmd.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
    index e20dea5c44f7..6a8274caa3bc 100644
    --- a/drivers/nvme/target/admin-cmd.c
    +++ b/drivers/nvme/target/admin-cmd.c
    @@ -313,7 +313,7 @@ static void nvmet_execute_get_log_page(struct nvmet_req *req)
    case NVME_LOG_ANA:
    return nvmet_execute_get_log_page_ana(req);
    }
    - pr_err("unhandled lid %d on qid %d\n",
    + pr_debug("unhandled lid %d on qid %d\n",
    req->cmd->get_log_page.lid, req->sq->qid);
    req->error_loc = offsetof(struct nvme_get_log_page_command, lid);
    nvmet_req_complete(req, NVME_SC_INVALID_FIELD | NVME_SC_DNR);
    @@ -657,7 +657,7 @@ static void nvmet_execute_identify(struct nvmet_req *req)
    return nvmet_execute_identify_desclist(req);
    }

    - pr_err("unhandled identify cns %d on qid %d\n",
    + pr_debug("unhandled identify cns %d on qid %d\n",
    req->cmd->identify.cns, req->sq->qid);
    req->error_loc = offsetof(struct nvme_identify, cns);
    nvmet_req_complete(req, NVME_SC_INVALID_FIELD | NVME_SC_DNR);
    @@ -972,7 +972,7 @@ u16 nvmet_parse_admin_cmd(struct nvmet_req *req)
    return 0;
    }

    - pr_err("unhandled cmd %d on qid %d\n", cmd->common.opcode,
    + pr_debug("unhandled cmd %d on qid %d\n", cmd->common.opcode,
    req->sq->qid);
    req->error_loc = offsetof(struct nvme_common_command, opcode);
    return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-05-12 23:31    [W:6.161 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site