Messages in this thread | | | Date | Tue, 11 May 2021 19:34:49 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 2/3] x86/MCE/AMD: Helper function to check UMC v2 |
| |
On Tue, May 11, 2021 at 08:55:37PM +0530, Naveen Krishna Chatradhi wrote:
> Subject: Re: [PATCH 2/3] x86/MCE/AMD: Helper function to check UMC v2
The condensed patch description in the subject line should start with a uppercase letter and should be written in imperative tone:
"x86/MCE/AMD: Add a helper function... "
> Signed-off-by: Mukul Joshi <mukul.joshi@amd.com> > Reviewed-by: John Clements <John.Clements@amd.com> > Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
This is all fine and dandy but it needs your SOB too when you send the patch.
Please read Documentation/process/submitting-patches.rst
sections
Sign your work - the Developer's Certificate of Origin When to use Acked-by:, Cc:, and Co-developed-by:
> +bool is_smca_umc_v2(int bank) > +{ > + return (smca_get_bank_type(bank) == SMCA_UMC_V2); > +} > +EXPORT_SYMBOL_GPL(is_smca_umc_v2);
This addition looks useless when it doesn't have any users.
Also, I'm pretty sceptical this even makes sense to have it exported - I'm guessing this is for mce_amd.c but I can't say without seeing it in use.
The same remarks hold true for your patch 3.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |