Messages in this thread | | | Date | Tue, 11 May 2021 23:46:46 +0200 | From | Pali Rohár <> | Subject | Re: [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function |
| |
On Wednesday 05 May 2021 18:20:46 Andrew Lunn wrote: > On Wed, May 05, 2021 at 06:04:33PM +0200, Marek Behún wrote: > > On Mon, 3 May 2021 14:22:49 +0200 > > Andrew Lunn <andrew@lunn.ch> wrote: > > > > > On Thu, Apr 29, 2021 at 10:36:31AM +0200, Pali Rohár wrote: > > > > From: Marek Behún <kabel@kernel.org> > > > > > > > > The status decoding function mox_get_status() currently contains a dead > > > > code path: if the error status is not MBOX_STS_SUCCESS, it always > > > > returns -EIO, so the comparison to MBOX_STS_FAIL is never executed and > > > > we don't get the actual error code sent by the firmware. > > > > > > > > Fix this. > > > > > > > > Signed-off-by: Marek Behún <kabel@kernel.org> > > > > Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver") > > > > > > You have put a fixes tag here, meaning you want it in stable? How does > > > dead code elimination fulfil the stable requirements? > > > > > > Do any of these changes contain real fixes? > > > > > > Andrew > > > > Andrew, this is not dead code elimination. > > Please word you commit message differently. > > The status decoding function mox_get_status() currently contains an > incorrect check: ... > > Andrew
Andrew, Marek has already updated commit message and I have sent a new version v3 of this patch series with this update. It is OK now?
| |