lkml.org 
[lkml]   [2021]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH 5/5] tracing: Add the osnoise tracer
Date
Daniel Bristot de Oliveira <bristot@redhat.com> writes:

A quick nit:

> Documentation/trace/osnoise_tracer.rst | 149 ++
> include/linux/ftrace_irq.h | 16 +
> include/trace/events/osnoise.h | 141 ++
> kernel/trace/Kconfig | 34 +
> kernel/trace/Makefile | 1 +
> kernel/trace/trace.h | 9 +-
> kernel/trace/trace_entries.h | 27 +
> kernel/trace/trace_osnoise.c | 1714 ++++++++++++++++++++++++
> kernel/trace/trace_output.c | 72 +-
> 9 files changed, 2159 insertions(+), 4 deletions(-)
> create mode 100644 Documentation/trace/osnoise_tracer.rst
> create mode 100644 include/trace/events/osnoise.h
> create mode 100644 kernel/trace/trace_osnoise.c

When you create a new RST file, you need to add it to an index.rst (or
similar) file so that it gets incorporated into the docs build.

The document itself looks good on a quick read. If you're making
another pass over it, you might consider reducing the ``markup noise`` a
bit; we try to keep that to a minimum in the kernel docs. But otherwise
thanks for writing it!

jon

\
 
 \ /
  Last update: 2021-04-08 17:58    [W:0.179 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site