Messages in this thread | | | Subject | Re: [PATCH 1/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU | From | John Garry <> | Date | Thu, 8 Apr 2021 13:55:02 +0100 |
| |
On 08/04/2021 10:01, Jonathan Cameron wrote: > On Wed, 7 Apr 2021 21:40:05 +0100 > Will Deacon <will@kernel.org> wrote: > >> On Wed, Apr 07, 2021 at 05:49:02PM +0800, Qi Liu wrote: >>> PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported >>> to sample bandwidth, latency, buffer occupation etc. >>> >>> Each PMU RCiEP device monitors multiple root ports, and each RCiEP is >>> registered as a pmu in /sys/bus/event_source/devices, so users can >>> select target PMU, and use filter to do further sets. >>> >>> Filtering options contains: >>> event - select the event. >>> subevent - select the subevent. >>> port - select target root ports. Information of root ports >>> are shown under sysfs. >>> bdf - select requester_id of target EP device. >>> trig_len - set trigger condition for starting event statistics. >>> trigger_mode - set trigger mode. 0 means starting to statistic when >>> bigger than trigger condition, and 1 means smaller. >>> thr_len - set threshold for statistics. >>> thr_mode - set threshold mode. 0 means count when bigger than >>> threshold, and 1 means smaller. >>> >>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> >> >> Do you have a link to this review, please? > > Internal review, so drop the tag. > > Jonathan
Hi Will,
Are you implying that you would rather that any review for these drivers is done in public on the lists?
Cheers, John
| |