lkml.org 
[lkml]   [2021]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 11/18] asm-generic/io.h: implement pci_remap_cfgspace using ioremap_np
From
Date
On 08/04/2021 06.03, Will Deacon wrote:
>> I would rewrite above as
>>
>> void __iomem *ret;
>>
>> ret = ioremap_np(offset, size);
>> if (ret)
>> return ret;
>>
>> return ioremap(offset, size);
>
> Looks like it might be one of those rare occasions where the GCC ternary if
> extension thingy comes in handy:
>
> return ioremap_np(offset, size) ?: ioremap(offset, size);

Today I learned that this one is kosher in kernel code. Handy! Let's go
with that.

> Acked-by: Will Deacon <will@kernel.org>

Thanks!

--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub

\
 
 \ /
  Last update: 2021-04-08 13:01    [W:0.137 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site