Messages in this thread | | | Subject | Re: [PATCH v4 11/18] asm-generic/io.h: implement pci_remap_cfgspace using ioremap_np | From | Hector Martin <> | Date | Thu, 8 Apr 2021 20:01:25 +0900 |
| |
On 08/04/2021 06.03, Will Deacon wrote: >> I would rewrite above as >> >> void __iomem *ret; >> >> ret = ioremap_np(offset, size); >> if (ret) >> return ret; >> >> return ioremap(offset, size); > > Looks like it might be one of those rare occasions where the GCC ternary if > extension thingy comes in handy: > > return ioremap_np(offset, size) ?: ioremap(offset, size);
Today I learned that this one is kosher in kernel code. Handy! Let's go with that.
> Acked-by: Will Deacon <will@kernel.org>
Thanks!
-- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub
| |