lkml.org 
[lkml]   [2021]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 1/1] powerpc/iommu: Enable remaining IOMMU Pagesizes present in LoPAR
Date
Leonardo Bras <leobras.c@gmail.com> writes:
> On Thu, 2021-04-08 at 03:20 -0300, Leonardo Bras wrote:
>> > > +#define QUERY_DDW_PGSIZE_4K 0x01
>> > > +#define QUERY_DDW_PGSIZE_64K 0x02
>> > > +#define QUERY_DDW_PGSIZE_16M 0x04
>> > > +#define QUERY_DDW_PGSIZE_32M 0x08
>> > > +#define QUERY_DDW_PGSIZE_64M 0x10
>> > > +#define QUERY_DDW_PGSIZE_128M 0x20
>> > > +#define QUERY_DDW_PGSIZE_256M 0x40
>> > > +#define QUERY_DDW_PGSIZE_16G 0x80
>> >
>> > I'm not sure the #defines really gain us much vs just putting the
>> > literal values in the array below?
>>
>> My v1 did not use the define approach, what do you think of that?
>> http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210322190943.715368-1-leobras.c@gmail.com/
>>
>>
> (of course, it would be that without the pageshift defines also, using
> the __builtin_ctz() approach suggested by Alexey.)

Yeah I think I like that better.

cheers

\
 
 \ /
  Last update: 2021-04-08 11:09    [W:0.233 / U:1.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site