lkml.org 
[lkml]   [2021]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] usb: dwc3: xilinx: Remove the extra freeing of clocks
Date
The clocks are configured by devm_clk_bulk_get_all() in this driver. In
case of any error the clocks freeing will be handled automatically.
There is no need to explicitly free the clocks. Fix the same.

Fixes: 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms")
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
---
drivers/usb/dwc3/dwc3-xilinx.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
index f42f4cb..9cc3ad7 100644
--- a/drivers/usb/dwc3/dwc3-xilinx.c
+++ b/drivers/usb/dwc3/dwc3-xilinx.c
@@ -271,7 +271,6 @@ static int dwc3_xlnx_probe(struct platform_device *pdev)

err_clk_put:
clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
- clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);

return ret;
}
@@ -284,7 +283,6 @@ static int dwc3_xlnx_remove(struct platform_device *pdev)
of_platform_depopulate(dev);

clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
- clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);
priv_data->num_clocks = 0;

pm_runtime_disable(dev);
--
2.1.1
\
 
 \ /
  Last update: 2021-04-08 19:56    [W:0.049 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site