lkml.org 
[lkml]   [2021]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support
On Thu, Apr 08, 2021 at 05:26:40PM +0000, Min Li wrote:
> >
> > Again, please make this only one file.
> >
> Hi Greg, the 2 boards have some same named registers in idt82p33_reg.h and idt8a340_reg.h
> so if I put them all in the same file, there will be name conflicts.

That does not make sense, this is only one kernel module, with one .h
file in this patch, I do not see those other files you are talking
about...

And if you have named registers that are identical, and yet you only
work on one device, that feels like a design flaw somewhere :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-04-08 19:55    [W:1.310 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site