Messages in this thread | | | Subject | Re: [PATCH] media: Fix compilation error | From | Mikko Perttunen <> | Date | Wed, 7 Apr 2021 16:45:34 +0300 |
| |
On 7.4.2021 16.29, Hans Verkuil wrote: > On 02/04/2021 09:40, Bixuan Cui wrote: >> Fix the error: >> >> drivers/staging/media/tegra-video/vi.c:1180:4: >> error: implicit declaration of function 'host1x_syncpt_free' [-Werror,-Wimplicit-function-declaration] > > Against what tree is this being built? The mainline kernel doesn't have > host1x_syncpt_put, only host1x_syncpt_free.
This change was done only very recently, it's in linux-next and submitted for 5.13. I missed this one host1x_syncpt_free call in vi.c, but Thierry has already applied an equivalent patch on his end so the issue should be resolved.
Thanks, Mikko
> > Also, the subject line is very vague, something like this is much more descriptive: > > [PATCH] media: tegra-video: replace host1x_syncpt_free by host1x_syncpt_put > > Regards, > > Hans > >> >> Fixes: 3028a00c55bf ('gpu: host1x: Cleanup and refcounting for syncpoints') >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> >> --- >> drivers/staging/media/tegra-video/vi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c >> index 7e0cb5529b49..df5ca3596470 100644 >> --- a/drivers/staging/media/tegra-video/vi.c >> +++ b/drivers/staging/media/tegra-video/vi.c >> @@ -1177,7 +1177,7 @@ static int tegra_channel_host1x_syncpt_init(struct tegra_vi_channel *chan) >> mw_sp = host1x_syncpt_request(&vi->client, flags); >> if (!mw_sp) { >> dev_err(vi->dev, "failed to request memory ack syncpoint\n"); >> - host1x_syncpt_free(fs_sp); >> + host1x_syncpt_put(fs_sp); >> ret = -ENOMEM; >> goto free_syncpts; >> } >> >
| |