Messages in this thread | | | Date | Wed, 7 Apr 2021 15:51:48 +0530 | From | riteshh <> | Subject | Re: [PATCH 2/3] fsdax: Factor helper: dax_fault_actor() |
| |
On 21/04/07 02:32PM, Shiyang Ruan wrote: > The core logic in the two dax page fault functions is similar. So, move > the logic into a common helper function. Also, to facilitate the > addition of new features, such as CoW, switch-case is no longer used to > handle different iomap types. > > Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com> > Reviewed-by: Christoph Hellwig <hch@lst.de> > --- > fs/dax.c | 294 ++++++++++++++++++++++++++++--------------------------- > 1 file changed, 148 insertions(+), 146 deletions(-)
Thanks for addressing comments. A msg in cover letter acknowledging that the review comments mentioned here[1] were addressed is helpful for everyone.
Please feel free to add. Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
[1]: https://patchwork.kernel.org/project/linux-nvdimm/patch/20210319015237.993880-3-ruansy.fnst@fujitsu.com/
-ritesh
| |