lkml.org 
[lkml]   [2021]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/2] scsi: pm8001: clean up for white space
From
Date
On 4/5/21 11:39 PM, luojiaxing wrote:
>
> On 2021/4/3 0:01, Bart Van Assche wrote:
>> On 4/2/21 2:08 AM, Luo Jiaxing wrote:
>>>   #define AAP1_MEMMAP(r, c) \
>>> -    (*(u32 *)((u8*)pm8001_ha->memoryMap.region[AAP1].virt_ptr + (r)
>>> * 32 \
>>> +    (*(u32 *)((u8 *)pm8001_ha->memoryMap.region[AAP1].virt_ptr + (r)
>>> * 32 \
>>>       + (c)))
>> Since this macro is being modified, please convert it into an inline
>> function such that the type of the arguments can be verified by the
>> compiler.
>
> Sure, but still keep the function name as AAP1_MEMMAP?

The coding style requires lower case names for functions so the function
name probably should be converted to lower case.

Thanks,

Bart.

\
 
 \ /
  Last update: 2021-04-07 23:56    [W:0.127 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site