Messages in this thread | | | Subject | Re: [PATCH v1 1/2] scsi: pm8001: clean up for white space | From | Bart Van Assche <> | Date | Wed, 7 Apr 2021 14:56:15 -0700 |
| |
On 4/5/21 11:39 PM, luojiaxing wrote: > > On 2021/4/3 0:01, Bart Van Assche wrote: >> On 4/2/21 2:08 AM, Luo Jiaxing wrote: >>> #define AAP1_MEMMAP(r, c) \ >>> - (*(u32 *)((u8*)pm8001_ha->memoryMap.region[AAP1].virt_ptr + (r) >>> * 32 \ >>> + (*(u32 *)((u8 *)pm8001_ha->memoryMap.region[AAP1].virt_ptr + (r) >>> * 32 \ >>> + (c))) >> Since this macro is being modified, please convert it into an inline >> function such that the type of the arguments can be verified by the >> compiler. > > Sure, but still keep the function name as AAP1_MEMMAP?
The coding style requires lower case names for functions so the function name probably should be converted to lower case.
Thanks,
Bart.
| |