Messages in this thread | | | Date | Wed, 7 Apr 2021 18:05:46 +0200 | From | Jan Kara <> | Subject | Re: [PATCH] inotify: fix minmax.cocci warnings |
| |
On Tue 06-04-21 22:49:26, Julia Lawall wrote: > From: kernel test robot <lkp@intel.com> > > Opportunity for min(). > > Generated by: scripts/coccinelle/misc/minmax.cocci > > Fixes: 8636e3295ce3 ("coccinelle: misc: add minmax script") > CC: Denis Efremov <efremov@linux.com> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: kernel test robot <lkp@intel.com> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr> ... > --- a/fs/notify/inotify/inotify_user.c > +++ b/fs/notify/inotify/inotify_user.c > @@ -382,7 +382,7 @@ static int inotify_add_to_idr(struct idr > > spin_unlock(idr_lock); > idr_preload_end(); > - return ret < 0 ? ret : 0; > + return min(ret, 0); > }
Honestly, while previous expression is a standard idiom for "if 'ret' holds an error, return it", the new expression is harder to understand for me. So I prefer to keep things as they are in this particular case...
Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |