Messages in this thread | | | Subject | Re: [PATCH v6 1/4] dt-bindings: Introduce SoC sleep stats bindings | From | Maulik Shah <> | Date | Tue, 6 Apr 2021 11:55:33 +0530 |
| |
Hi,
On 3/12/2021 10:45 PM, Bjorn Andersson wrote: > On Thu 04 Feb 08:21 CST 2021, Maulik Shah wrote: > >> From: Mahesh Sivasubramanian <msivasub@codeaurora.org> >> >> Add device binding documentation for Qualcomm Technologies, Inc. (QTI) >> SoC sleep stats driver. The driver is used for displaying SoC sleep >> statistic maintained by Always On Processor or Resource Power Manager. >> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org> >> Signed-off-by: Lina Iyer <ilina@codeaurora.org> >> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> >> Reviewed-by: Stephen Boyd <swboyd@chromium.org> >> --- >> .../bindings/soc/qcom/soc-sleep-stats.yaml | 46 ++++++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml >> >> diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml >> new file mode 100644 >> index 0000000..1e012ba >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml >> @@ -0,0 +1,46 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings >> + >> +maintainers: >> + - Maulik Shah <mkshah@codeaurora.org> >> + - Lina Iyer <ilina@codeaurora.org> >> + >> +description: >> + Always On Processor/Resource Power Manager maintains statistics of the SoC >> + sleep modes involving powering down of the rails and oscillator clock. >> + >> + Statistics includes SoC sleep mode type, number of times low power mode were >> + entered, time of last entry, time of last exit and accumulated sleep duration. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,rpmh-sleep-stats >> + - qcom,rpm-sleep-stats >> + >> + reg: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + >> +examples: >> + # Example of rpmh sleep stats >> + - | >> + rpmh-sleep-stats@c3f0000 { >> + compatible = "qcom,rpmh-sleep-stats"; >> + reg = <0 0x0c3f0000 0 0x400>; > The example is built with #address-cells = <1> and #size-cells = <1>, so > this needs to be reg = <0x0c3f0000 0x400>. > > Regards, > Bjorn
Thanks, Fixed in v7.
Thanks, Maulik > >> + }; >> + # Example of rpm sleep stats >> + - | >> + rpm-sleep-stats@4690000 { >> + compatible = "qcom,rpm-sleep-stats"; >> + reg = <0 0x04690000 0 0x400>; >> + }; >> +... >> -- >> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member >> of Code Aurora Forum, hosted by The Linux Foundation >> -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |