lkml.org 
[lkml]   [2021]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h
On Tue, Apr 6, 2021 at 4:11 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Apr 06, 2021 at 03:05:56PM +0200, Fabio M. De Francesco wrote:
> > Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols
> > are not used anywhere else, therefore this patch does not break the driver.
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
>
> If this is "v2", you need to put below the --- line what changed from
> v1.

It is a v2 only because you made me notice that I forgot to cc
linux-staging and linux-kernel.
So I sent it again, but probably I shouldn't have changed the version
number because nothing else had changed.

> Please fix up and send a v3.
>

No problem at all. I can explain in the patch v3 what I wrote above.
May you please confirm that a patch v3 is the correct solution even
when nothing changes in the code?

Thanks for your help,

Fabio

> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2021-04-06 16:35    [W:0.049 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site