lkml.org 
[lkml]   [2021]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] sched/fair: Consider SMT in ASYM_PACKING load balance
    On Mon, Apr 05, 2021 at 09:11:07PM -0700, Ricardo Neri wrote:
    > @@ -8507,6 +8619,10 @@ static bool update_sd_pick_busiest(struct lb_env *env,
    > if (!sgs->sum_h_nr_running)
    > return false;
    >
    > + if (sgs->group_type == group_asym_packing &&
    > + !asym_can_pull_tasks(env->dst_cpu, sds, sgs, sg))
    > + return false;

    All of this makes my head hurt; but afaict this isn't right.

    Your update_sg_lb_stats() change makes that we unconditionally set
    sgs->group_asym_packing, and then this is to undo that. But it's not
    clear this covers all cases right.

    Even if !sched_asym_prefer(), we could end up selecting this sg as
    busiest, but you're just bailing out here.

    \
     
     \ /
      Last update: 2021-04-06 15:08    [W:3.015 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site