lkml.org 
[lkml]   [2021]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] arm: patch: FUNCTION_GRAPH_TRACER depends on CPU_ENDIAN_BE8 or !CPU_ENDIAN_BE32
On Tue, 6 Apr 2021 18:23:51 +0800
Zhang Jianhua <zhangjianhua18@huawei.com> wrote:

> If CONFIG_FUNCTION_GRAPH_TRACER=y, the following errors will be seen
> while compiling patch.c
>
> arch/arm/kernel/patch.c: In function ‘__patch_text_real’:
> arch/arm/kernel/patch.c:94:11: error: implicit declaration of function
> ‘__opcode_to_mem_thumb32’; did you mean ‘__opcode_to_mem_thumb16’?
> [-Werror=implicit-function-declaration]
> insn = __opcode_to_mem_thumb32(insn);
> ^~~~~~~~~~~~~~~~~~~~~~~
> __opcode_to_mem_thumb16
>
> Signed-off-by: Zhang Jianhua <zhangjianhua18@huawei.com>
> ---
> kernel/trace/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 7fa82778c3e6..fbf5fd80f105 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -177,6 +177,7 @@ config FUNCTION_GRAPH_TRACER
> depends on HAVE_FUNCTION_GRAPH_TRACER
> depends on FUNCTION_TRACER
> depends on !X86_32 || !CC_OPTIMIZE_FOR_SIZE
> + depends on CPU_ENDIAN_BE8 || !CPU_ENDIAN_BE32

Doesn't this break 32 bit big endian powerpc?

Not to mention, my config doesn't have either of those.

NACK

-- Steve

> default y
> help
> Enable the kernel to trace a function at both its return

\
 
 \ /
  Last update: 2021-04-06 15:07    [W:0.051 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site