Messages in this thread | | | Date | Tue, 6 Apr 2021 11:09:01 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v3 13/25] x86/sgx: Add helpers to expose ECREATE and EINIT to KVM |
| |
On Tue, Apr 06, 2021 at 08:59:58PM +1200, Kai Huang wrote: > OK. My thinking was that, returning negative error value basically means guest > will be killed.
You need to define how you're going to handle invalid input from the guest. If that guest is considered malicious, then sure, killing it makes sense.
> For the case access_ok() fails for @secs or other user pointers, it > seems killing guest is a little it overkill,
So don't kill it then - just don't allow it to create an enclave because it is doing stupid crap.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |