Messages in this thread | | | From | Robert Foss <> | Date | Tue, 6 Apr 2021 10:30:58 +0200 | Subject | Re: [PATCH -next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init() |
| |
Hi Yang,
Thanks for the fix.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
On Fri, 2 Apr 2021 at 11:29, Yang Yingliang <yangyingliang@huawei.com> wrote: > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/media/platform/qcom/camss/camss-csid.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c > index 463760c29294..cc11fbfdae13 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid.c > +++ b/drivers/media/platform/qcom/camss/camss-csid.c > @@ -568,10 +568,8 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid, > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]); > csid->base = devm_ioremap_resource(dev, r); > - if (IS_ERR(csid->base)) { > - dev_err(dev, "could not map memory\n"); > + if (IS_ERR(csid->base)) > return PTR_ERR(csid->base); > - } > > /* Interrupt */ > > -- > 2.25.1 >
| |