lkml.org 
[lkml]   [2021]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH RFC net 0/2] lantiq: GSWIP: two more fixes
    Date
    Hello,

    after my last patch got accepted and is now in net as commit
    3e6fdeb28f4c33 ("net: dsa: lantiq_gswip: Let GSWIP automatically set
    the xMII clock") [0] some more people from the OpenWrt community
    (many thanks to everyone involved) helped test the GSWIP driver: [1]

    It turns out that the previous fix does not work for all boards.
    There's no regression, but it doesn't fix as many problems as I
    thought. This is why two more fixes are needed:
    - the first one solves many (four known but probably there are
    a few extra hidden ones) reported bugs with the GSWIP where no
    traffic would flow. Not all circumstances are fully understood
    but testing shows that switching away from PHY auto polling
    solves all of them
    - while investigating the different problems which are addressed
    by the first patch some small issues with the existing code were
    found. These are addressed by the second patch

    Why am I sending this as RFC then?
    Because I am not sure where to place the link configuration bits
    in the first patch (as I don't understand why phylink_mac_config
    and also phylink_mac_link_up both have the required parameters
    to configure the link, just in differnet formats):
    - in gswip_phylink_mac_config
    - in gswip_phylink_mac_link_up
    - in both

    Any feedback is very welcome on this topic!

    I have already gotten Hauke's Acked-by off-list. He's Cc'ed so he
    can speak up if he changes his opinion or finds some issue with
    the patches still.


    Best regards,
    Martin


    [0] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=3e6fdeb28f4c331acbd27bdb0effc4befd4ef8e8
    [1] https://github.com/openwrt/openwrt/pull/3085


    Martin Blumenstingl (2):
    net: dsa: lantiq_gswip: Don't use PHY auto polling
    net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits

    drivers/net/dsa/lantiq_gswip.c | 211 ++++++++++++++++++++++++++++-----
    1 file changed, 183 insertions(+), 28 deletions(-)

    --
    2.31.1

    \
     
     \ /
      Last update: 2021-04-06 22:36    [W:3.417 / U:0.804 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site