lkml.org 
[lkml]   [2021]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/4] occ: fsi and hwmon: Fixes for polling un-initialized OCC
From
Date
On Tue, 2021-02-09 at 11:12 -0600, Eddie James wrote:
> In the event that the OCC is not initialized when the driver sends a
> poll
> command, the driver may receive an invalid response. This isn't an
> error
> condition unless there is no valid response before the timeout
> expires. So
> change the starting sequence number and check for the un-initialized
> OCC
> state before returning the response in order to detect this condition
> and
> continue waiting if necessary.

Hi Joel,

Do you have any comments on the FSI side of this series?

Thanks,
Eddie

>
> Eddie James (4):
> fsi: occ: Don't accept response from un-initialized OCC
> fsi: occ: Log error for checksum failure
> hwmon: (occ) Start sequence number at one
> hwmon: (occ) Print response status in first poll error message
>
> drivers/fsi/fsi-occ.c | 11 ++++++++---
> drivers/hwmon/occ/common.c | 7 +++++--
> 2 files changed, 13 insertions(+), 5 deletions(-)
>

\
 
 \ /
  Last update: 2021-04-05 17:35    [W:1.228 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site