Messages in this thread | | | Subject | Re: [PATCH 0/4] occ: fsi and hwmon: Fixes for polling un-initialized OCC | From | Eddie James <> | Date | Mon, 05 Apr 2021 10:33:54 -0500 |
| |
On Tue, 2021-02-09 at 11:12 -0600, Eddie James wrote: > In the event that the OCC is not initialized when the driver sends a > poll > command, the driver may receive an invalid response. This isn't an > error > condition unless there is no valid response before the timeout > expires. So > change the starting sequence number and check for the un-initialized > OCC > state before returning the response in order to detect this condition > and > continue waiting if necessary.
Hi Joel,
Do you have any comments on the FSI side of this series?
Thanks, Eddie
> > Eddie James (4): > fsi: occ: Don't accept response from un-initialized OCC > fsi: occ: Log error for checksum failure > hwmon: (occ) Start sequence number at one > hwmon: (occ) Print response status in first poll error message > > drivers/fsi/fsi-occ.c | 11 ++++++++--- > drivers/hwmon/occ/common.c | 7 +++++-- > 2 files changed, 13 insertions(+), 5 deletions(-) >
| |