Messages in this thread | | | Date | Mon, 5 Apr 2021 14:58:43 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH] h8300: rearrange headers inclusion order in asm/bitops |
| |
On Thu, Apr 01, 2021 at 01:32:28PM -0700, Yury Norov wrote: > This patch fixes [next-20210401] commit a5145bdad3ff ("arch: rearrange
"This patch fixes [next-20210401] commit ..." ==>
"The commit ...
> headers inclusion order in asm/bitops for m68k and sh").
...fixed header ordering issue."
> h8300 has > similar problem, which was overlooked by me.
> h8300 includes bitmap/{find,le}.h prior to ffs/fls headers. New fast-path > implementation in find.h requires ffs/fls. Reordering the headers inclusion > sequence helps to prevent compile-time implicit function declaration error.
Whit above commit message rephrasing: Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Yury Norov <yury.norov@gmail.com> > --- > arch/h8300/include/asm/bitops.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/h8300/include/asm/bitops.h b/arch/h8300/include/asm/bitops.h > index 7aa16c732aa9..c867a80cab5b 100644 > --- a/arch/h8300/include/asm/bitops.h > +++ b/arch/h8300/include/asm/bitops.h > @@ -9,6 +9,10 @@ > > #include <linux/compiler.h> > > +#include <asm-generic/bitops/fls.h> > +#include <asm-generic/bitops/__fls.h> > +#include <asm-generic/bitops/fls64.h> > + > #ifdef __KERNEL__ > > #ifndef _LINUX_BITOPS_H > @@ -173,8 +177,4 @@ static inline unsigned long __ffs(unsigned long word) > > #endif /* __KERNEL__ */ > > -#include <asm-generic/bitops/fls.h> > -#include <asm-generic/bitops/__fls.h> > -#include <asm-generic/bitops/fls64.h> > - > #endif /* _H8300_BITOPS_H */ > -- > 2.25.1 >
-- With Best Regards, Andy Shevchenko
| |