lkml.org 
[lkml]   [2021]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] [PATCH 2/2] qede: Use 'skb_add_rx_frag()' instead of hand coding it
Date
> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Sunday, April 4, 2021 6:13 PM
> To: Ariel Elior <aelior@marvell.com>; GR-everest-linux-l2 <GR-everest-linux-
> l2@marvell.com>; davem@davemloft.net; kuba@kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org; Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Subject: [EXT] [PATCH 2/2] qede: Use 'skb_add_rx_frag()' instead of hand coding
> it
>
> External Email
>
> ----------------------------------------------------------------------
> Some lines of code can be merged into an equivalent 'skb_add_rx_frag()'
> call which is less verbose.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/qlogic/qede/qede_fp.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> index ee3e45e38cb7..8e150dd4f899 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> @@ -1209,12 +1209,9 @@ static int qede_rx_build_jumbo(struct qede_dev
> *edev,
> dma_unmap_page(rxq->dev, bd->mapping,
> PAGE_SIZE, DMA_FROM_DEVICE);
>
> - skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
> - bd->data, rxq->rx_headroom, cur_size);
> + skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, bd->data,
> + rxq->rx_headroom, cur_size, PAGE_SIZE);
>
> - skb->truesize += PAGE_SIZE;
> - skb->data_len += cur_size;
> - skb->len += cur_size;
> pkt_len -= cur_size;
> }
>
> --
> 2.27.0

Thank you Christophe.
Acked-by: Manish Chopra <manishc@marvell.com>


\
 
 \ /
  Last update: 2021-04-05 12:09    [W:0.119 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site