lkml.org 
[lkml]   [2021]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 118/126] usb: dwc3: gadget: Clear DEP flags after stop transfers in ep disable
    Date
    From: Wesley Cheng <wcheng@codeaurora.org>

    commit 5aef629704ad4d983ecf5c8a25840f16e45b6d59 upstream.

    Ensure that dep->flags are cleared until after stop active transfers
    is completed. Otherwise, the ENDXFER command will not be executed
    during ep disable.

    Fixes: f09ddcfcb8c5 ("usb: dwc3: gadget: Prevent EP queuing while stopping transfers")
    Cc: stable <stable@vger.kernel.org>
    Reported-and-tested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
    Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
    Link: https://lore.kernel.org/r/1616610664-16495-1-git-send-email-wcheng@codeaurora.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/dwc3/gadget.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/usb/dwc3/gadget.c
    +++ b/drivers/usb/dwc3/gadget.c
    @@ -791,10 +791,6 @@ static int __dwc3_gadget_ep_disable(stru
    reg &= ~DWC3_DALEPENA_EP(dep->number);
    dwc3_writel(dwc->regs, DWC3_DALEPENA, reg);

    - dep->stream_capable = false;
    - dep->type = 0;
    - dep->flags = 0;
    -
    /* Clear out the ep descriptors for non-ep0 */
    if (dep->number > 1) {
    dep->endpoint.comp_desc = NULL;
    @@ -803,6 +799,10 @@ static int __dwc3_gadget_ep_disable(stru

    dwc3_remove_requests(dwc, dep);

    + dep->stream_capable = false;
    + dep->type = 0;
    + dep->flags = 0;
    +
    return 0;
    }


    \
     
     \ /
      Last update: 2021-04-05 11:41    [W:4.264 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site