lkml.org 
[lkml]   [2021]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 132/152] usb: musb: Fix suspend with devices connected for a64
    Date
    From: Tony Lindgren <tony@atomide.com>

    commit 92af4fc6ec331228aca322ca37c8aea7b150a151 upstream.

    Pinephone running on Allwinner A64 fails to suspend with USB devices
    connected as reported by Bhushan Shah <bshah@kde.org>. Reverting
    commit 5fbf7a253470 ("usb: musb: fix idling for suspend after
    disconnect interrupt") fixes the issue.

    Let's add suspend checks also for suspend after disconnect interrupt
    quirk handling like we already do elsewhere.

    Fixes: 5fbf7a253470 ("usb: musb: fix idling for suspend after disconnect interrupt")
    Reported-by: Bhushan Shah <bshah@kde.org>
    Tested-by: Bhushan Shah <bshah@kde.org>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Link: https://lore.kernel.org/r/20210324071142.42264-1-tony@atomide.com
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/musb/musb_core.c | 12 ++++++++----
    1 file changed, 8 insertions(+), 4 deletions(-)

    --- a/drivers/usb/musb/musb_core.c
    +++ b/drivers/usb/musb/musb_core.c
    @@ -2004,10 +2004,14 @@ static void musb_pm_runtime_check_sessio
    MUSB_DEVCTL_HR;
    switch (devctl & ~s) {
    case MUSB_QUIRK_B_DISCONNECT_99:
    - musb_dbg(musb, "Poll devctl in case of suspend after disconnect\n");
    - schedule_delayed_work(&musb->irq_work,
    - msecs_to_jiffies(1000));
    - break;
    + if (musb->quirk_retries && !musb->flush_irq_work) {
    + musb_dbg(musb, "Poll devctl in case of suspend after disconnect\n");
    + schedule_delayed_work(&musb->irq_work,
    + msecs_to_jiffies(1000));
    + musb->quirk_retries--;
    + break;
    + }
    + fallthrough;
    case MUSB_QUIRK_B_INVALID_VBUS_91:
    if (musb->quirk_retries && !musb->flush_irq_work) {
    musb_dbg(musb,

    \
     
     \ /
      Last update: 2021-04-05 11:22    [W:4.217 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site