lkml.org 
[lkml]   [2021]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 122/152] extcon: Fix error handling in extcon_dev_register
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit d3bdd1c3140724967ca4136755538fa7c05c2b4e ]

    When devm_kcalloc() fails, we should execute device_unregister()
    to unregister edev->dev from system.

    Fixes: 046050f6e623e ("extcon: Update the prototype of extcon_register_notifier() with enum extcon")
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/extcon/extcon.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
    index 0a6438cbb3f3..e7a9561a826d 100644
    --- a/drivers/extcon/extcon.c
    +++ b/drivers/extcon/extcon.c
    @@ -1241,6 +1241,7 @@ int extcon_dev_register(struct extcon_dev *edev)
    sizeof(*edev->nh), GFP_KERNEL);
    if (!edev->nh) {
    ret = -ENOMEM;
    + device_unregister(&edev->dev);
    goto err_dev;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-04-05 11:22    [W:2.662 / U:1.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site