lkml.org 
[lkml]   [2021]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 2/8] hugetlb: no need to drop hugetlb_lock to call cma_release
    Date
    Now that cma_release is non-blocking and irq safe, there is no need to
    drop hugetlb_lock before calling.

    Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
    Acked-by: Roman Gushchin <guro@fb.com>
    Acked-by: Michal Hocko <mhocko@suse.com>
    ---
    mm/hugetlb.c | 6 ------
    1 file changed, 6 deletions(-)

    diff --git a/mm/hugetlb.c b/mm/hugetlb.c
    index 3c3e4baa4156..1d62f0492e7b 100644
    --- a/mm/hugetlb.c
    +++ b/mm/hugetlb.c
    @@ -1353,14 +1353,8 @@ static void update_and_free_page(struct hstate *h, struct page *page)
    set_compound_page_dtor(page, NULL_COMPOUND_DTOR);
    set_page_refcounted(page);
    if (hstate_is_gigantic(h)) {
    - /*
    - * Temporarily drop the hugetlb_lock, because
    - * we might block in free_gigantic_page().
    - */
    - spin_unlock(&hugetlb_lock);
    destroy_compound_gigantic_page(page, huge_page_order(h));
    free_gigantic_page(page, huge_page_order(h));
    - spin_lock(&hugetlb_lock);
    } else {
    __free_pages(page, huge_page_order(h));
    }
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-04-06 01:03    [W:4.389 / U:0.728 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site