Messages in this thread | | | Date | Mon, 5 Apr 2021 04:04:49 +0300 | From | Laurent Pinchart <> | Subject | Re: [PATCH v3 11/12] drm/bridge: ti-sn65dsi86: Print an error if we fallback to panel modes |
| |
Hi Doug,
Thank you for the patch.
On Fri, Apr 02, 2021 at 03:28:45PM -0700, Douglas Anderson wrote: > Now that we can properly read the EDID for modes there should be no > reason to fallback to the fixed modes that our downstream panel driver > provides us. Let's make that clear by: > - Putting an error message in the logs if we fall back. > - Putting a comment in saying what's going on. > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> --- > > (no changes since v1) > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index fb50f9f95b0f..3b61898cf9cb 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -303,6 +303,13 @@ static int ti_sn_bridge_connector_get_modes(struct drm_connector *connector) > return num; > } > > + /* > + * Ideally this should never happen and we could remove the fallback > + * but let's preserve old behavior. > + */ > + DRM_DEV_ERROR(pdata->dev, > + "Failed to read EDID; falling back to panel modes"); > + > exit: > return drm_panel_get_modes(pdata->panel, connector); > }
-- Regards,
Laurent Pinchart
| |