lkml.org 
[lkml]   [2021]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 3/8] KVM: arm/arm64: vgic: Reset base address on kvm_vgic_dist_destroy()
    Date
    On vgic_dist_destroy(), the addresses are not reset. However for
    kvm selftest purpose this would allow to continue the test execution
    even after a failure when running KVM_RUN. So let's reset the
    base addresses.

    Signed-off-by: Eric Auger <eric.auger@redhat.com>

    ---

    v1 -> v2:
    - use dist-> in the else and add braces
    ---
    arch/arm64/kvm/vgic/vgic-init.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/arch/arm64/kvm/vgic/vgic-init.c b/arch/arm64/kvm/vgic/vgic-init.c
    index 052917deb149..cf6faa0aeddb 100644
    --- a/arch/arm64/kvm/vgic/vgic-init.c
    +++ b/arch/arm64/kvm/vgic/vgic-init.c
    @@ -335,13 +335,16 @@ static void kvm_vgic_dist_destroy(struct kvm *kvm)
    kfree(dist->spis);
    dist->spis = NULL;
    dist->nr_spis = 0;
    + dist->vgic_dist_base = VGIC_ADDR_UNDEF;

    - if (kvm->arch.vgic.vgic_model == KVM_DEV_TYPE_ARM_VGIC_V3) {
    + if (dist->vgic_model == KVM_DEV_TYPE_ARM_VGIC_V3) {
    list_for_each_entry_safe(rdreg, next, &dist->rd_regions, list) {
    list_del(&rdreg->list);
    kfree(rdreg);
    }
    INIT_LIST_HEAD(&dist->rd_regions);
    + } else {
    + dist->vgic_cpu_base = VGIC_ADDR_UNDEF;
    }

    if (vgic_has_its(kvm))
    @@ -362,6 +365,7 @@ void kvm_vgic_vcpu_destroy(struct kvm_vcpu *vcpu)
    vgic_flush_pending_lpis(vcpu);

    INIT_LIST_HEAD(&vgic_cpu->ap_list_head);
    + vgic_cpu->rd_iodev.base_addr = VGIC_ADDR_UNDEF;
    }

    /* To be called with kvm->lock held */
    --
    2.26.3
    \
     
     \ /
      Last update: 2021-04-04 19:24    [W:3.959 / U:1.828 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site