Messages in this thread | | | Date | Fri, 30 Apr 2021 18:11:44 +0300 | From | Mike Rapoport <> | Subject | Re: [RFT PATCH] MIPS: Octeon: drop dependency on CONFIG_HOLES_IN_ZONE |
| |
On Fri, Apr 30, 2021 at 12:42:56PM +0200, Thomas Bogendoerfer wrote: > On Fri, Apr 30, 2021 at 12:35:32PM +0300, Mike Rapoport wrote: > > Hi Thomas, > > > > On Thu, Apr 29, 2021 at 11:06:32PM +0200, Thomas Bogendoerfer wrote: > > > On Sun, Apr 18, 2021 at 12:35:12PM +0300, Mike Rapoport wrote: > > > > I'd really appreciate if somebody with access to an Octeon system could > > > > test this patch. > > > > > > Tested on an Ubiquiti edgerouter 12. Works with problem and I haven't > > > even seen a change in memory output. > > > > Is "works with problem" a misprint or something went wrong? > > that should have been "without problem".
Thanks for the clarification :)
> All good in my test, but that was more or less booting and checking > memory log messages.
Well, this is way better than build testing I did. The commit 465aaed0030b ("MIPS: Octeon: Select CONFIG_HOLES_IN_ZONE") that added CONFIG_HOLES_IN_ZONE for Octeons talked about crashes at boot time, so boot testing seems appropriate.
The only concern, is peculiar memory configuration Octeon may have with Linux and non-Linux "partitions" that will be different on different systems, but nevertheless I think the generic mm nowadays is robust enough to cope with those without CONFIG_HOLES_IN_ZONE.
I presumed the patch would go via MIPS tree, so it's you call Thomas.
-- Sincerely yours, Mike.
| |