Messages in this thread | | | Date | Fri, 30 Apr 2021 17:08:20 +0200 | From | Fabio Aiuto <> | Subject | Re: [PATCH 02/43] staging: rlt8723bs: remove if-else blocks left empty by ODM_RT_TRACE deletion |
| |
On Fri, Apr 30, 2021 at 03:02:38PM +0000, Bryan Brattlof wrote: > On Fri, Apr 30, 2021 at 04:50:00PM +0200, Fabio Aiuto wrote: > >On Fri, Apr 30, 2021 at 02:31:08PM +0000, Bryan Brattlof wrote: > >> On Fri, Apr 30, 2021 at 09:43:20AM +0200, Fabio Aiuto wrote: > >> >remove if-else blocks left empty by ODM_RT_TRACE deletion. > >> >remove unused variables to suppress compiler warnings. > >> > > >> >Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com> > >> > > >> > >> Hi Fabio! > >> > >> I just wanted to point out a spelling mistake in the title 'rlt8723bs' > >> in the off chance you submit a v2. > >> > >> Way to go switching this over to netdev btw. > > > >what do you mean exactly? > > > > I was just praising you for all the work you are putting into this > driver. :)
thank you Bryan, I'm not to praise for my english :-D
> > > > >> -- > >> ~Bryan > >> > > > >Hi Brian, > > > >thank you! Ouch I've just sent a v2 for other issues... > >no problem I will send a v3, sorry all for spamming. > > > > Don't worry about me. I would wait until Greg and others have feedback > on your v2 before sending a v3 with this minor nitpick. > > -- > ~Bryan >
too late, v3 submitted:(. But I understand what you say and agreed. So let's wait a little more next time.
thank you,
fabio.
| |