lkml.org 
[lkml]   [2021]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 15/16] soc: imx: gpcv2: support reset defer probe
From
Date


On 2021/4/29 22:30, Lucas Stach wrote:
> Am Donnerstag, dem 29.04.2021 um 15:30 +0800 schrieb Peng Fan (OSS):
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> When gpcv2 probe, the reset controller might not be ready, so we need
>> defer probe
>
> I agree with Ahmad. dev_err_probe properly propagates the PROBE_DEFER
> return, so this patch should be dropped.

Sure. Drop in V2.

Thanks,
Peng.

>
> Regards,
> Lucas
>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>>  drivers/soc/imx/gpcv2.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
>> index 072f519462a5..49dd137f6b94 100644
>> --- a/drivers/soc/imx/gpcv2.c
>> +++ b/drivers/soc/imx/gpcv2.c
>> @@ -784,9 +784,12 @@ static int imx_pgc_domain_probe(struct platform_device *pdev)
>>   "Failed to get domain's clocks\n");
>>
>>
>>
>>
>>   domain->reset = devm_reset_control_array_get_optional_exclusive(domain->dev);
>> - if (IS_ERR(domain->reset))
>> + if (IS_ERR(domain->reset)) {
>> + if (PTR_ERR(domain->reset) == -EPROBE_DEFER)
>> + return -EPROBE_DEFER;
>>   return dev_err_probe(domain->dev, PTR_ERR(domain->reset),
>>   "Failed to get domain's resets\n");
>> + }
>>
>>
>>
>>
>>   pm_runtime_enable(domain->dev);
>>
>>
>>
>>
>
>

\
 
 \ /
  Last update: 2021-04-30 06:53    [W:1.256 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site