lkml.org 
[lkml]   [2021]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] platform/chrome: Update cros_ec sysfs attributes on sensors discovery
Hi Gwendal,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on chrome-platform-linux/for-next]
[also build test ERROR on linux/master linus/master v5.12-rc5 next-20210401]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Gwendal-Grignou/platform-chrome-Update-cros_ec-sysfs-attributes-on-sensors-discovery/20210403-142205
base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
config: arm-randconfig-r015-20210403 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 0fe8af94688aa03c01913c2001d6a1a911f42ce6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/f4bc64b0efbd2fb964478a0a2aab4ba2fc827447
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gwendal-Grignou/platform-chrome-Update-cros_ec-sysfs-attributes-on-sensors-discovery/20210403-142205
git checkout f4bc64b0efbd2fb964478a0a2aab4ba2fc827447
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/platform/chrome/cros_ec_sysfs.c:348:17: error: assigning to 'struct attribute_group *' from 'const struct attribute_group *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
ec_dev->group = &cros_ec_attr_group;
^ ~~~~~~~~~~~~~~~~~~~
1 error generated.


vim +348 drivers/platform/chrome/cros_ec_sysfs.c

337
338 static int cros_ec_sysfs_probe(struct platform_device *pd)
339 {
340 struct cros_ec_dev *ec_dev = dev_get_drvdata(pd->dev.parent);
341 struct device *dev = &pd->dev;
342 int ret;
343
344 ret = sysfs_create_group(&ec_dev->class_dev.kobj, &cros_ec_attr_group);
345 if (ret < 0)
346 dev_err(dev, "failed to create attributes. err=%d\n", ret);
347 else
> 348 ec_dev->group = &cros_ec_attr_group;
349
350 return ret;
351 }
352

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-04-03 10:06    [W:0.202 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site