lkml.org 
[lkml]   [2021]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 075/190] Revert "gma/gma500: fix a memory disclosure bug due to uninitialized bytes"
    Hi!

    > drivers/gpu/drm/gma500/cdv_intel_display.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c
    > index 5d3302249779..f89c2088dc2d 100644
    > --- a/drivers/gpu/drm/gma500/cdv_intel_display.c
    > +++ b/drivers/gpu/drm/gma500/cdv_intel_display.c
    > @@ -405,8 +405,6 @@ static bool cdv_intel_find_dp_pll(const struct gma_limit_t *limit,
    > struct gma_crtc *gma_crtc = to_gma_crtc(crtc);
    > struct gma_clock_t clock;
    >
    > - memset(&clock, 0, sizeof(clock));
    > -
    > switch (refclk) {
    > case 27000:
    > if (target < 200000) {

    Original description is correct, we are returning with .vco and .dot
    unitialized which is at least very very ugly, so we should keep the
    memset and not revert this.

    Best regards,
    Pavel
    --
    http://www.livejournal.com/~pavelmachek
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-04-29 22:24    [W:2.149 / U:29.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site