lkml.org 
[lkml]   [2021]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 057/190] Revert "media: saa7146: Avoid using BUG_ON as an assertion"
    Hi!

    I doubt this is malicious, and BUG()s are ugly. I'd suggest keeping
    this.

    Best regards,
    Pavel


    > diff --git a/drivers/media/common/saa7146/saa7146_video.c b/drivers/media/common/saa7146/saa7146_video.c
    > index 7b8795eca589..d9d7d82ca451 100644
    > --- a/drivers/media/common/saa7146/saa7146_video.c
    > +++ b/drivers/media/common/saa7146/saa7146_video.c
    > @@ -345,8 +345,7 @@ static int video_begin(struct saa7146_fh *fh)
    >
    > fmt = saa7146_format_by_fourcc(dev, vv->video_fmt.pixelformat);
    > /* we need to have a valid format set here */
    > - if (!fmt)
    > - return -EINVAL;
    > + BUG_ON(NULL == fmt);
    >
    > if (0 != (fmt->flags & FORMAT_IS_PLANAR)) {
    > resource = RESOURCE_DMA1_HPS|RESOURCE_DMA2_CLP|RESOURCE_DMA3_BRS;
    > @@ -399,8 +398,7 @@ static int video_end(struct saa7146_fh *fh, struct file *file)
    >
    > fmt = saa7146_format_by_fourcc(dev, vv->video_fmt.pixelformat);
    > /* we need to have a valid format set here */
    > - if (!fmt)
    > - return -EINVAL;
    > + BUG_ON(NULL == fmt);
    >
    > if (0 != (fmt->flags & FORMAT_IS_PLANAR)) {
    > resource = RESOURCE_DMA1_HPS|RESOURCE_DMA2_CLP|RESOURCE_DMA3_BRS;

    --
    http://www.livejournal.com/~pavelmachek
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-04-29 22:18    [W:2.154 / U:0.612 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site