lkml.org 
[lkml]   [2021]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 000/190] Revertion of all of the umn.edu commits
    Hi!

    > > Revert "drm/radeon: Fix reference count leaks caused by
    > > pm_runtime_get_sync"
    > > Revert "drm/radeon: fix multiple reference count leak"
    > > Revert "drm/amdkfd: Fix reference count leaks."
    >
    > I didn't review these carefully, but from a quick look they all seem
    > rather inconsequental. Either error paths that are very unlikely, or
    > drivers which are very dead (looking at the entire list, not just what
    > you reverted here).
    >
    > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

    So you are knowingly acking patch re-introducing bugs into kernel, because
    the bugs are minor? I don't believe that's an okay thing to do.

    Maybe something needs reverting, but lets not introduce bugs into kernel because they are
    "minor".

    Best regards,
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

    \
     
     \ /
      Last update: 2021-04-29 22:01    [W:2.093 / U:4.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site