lkml.org 
[lkml]   [2021]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm/amd/display: Remove duplicate include of hubp.h
Is your robot public available?

btw, applied to amd-staging-drm-next.

Thanks

On 04/29, Jiabing Wan wrote:
>
> >Nice catch!
> >
> >Are you using any tool to identify this problem?
>
> Yes, I have a robot including many detecting scripts :)
>
> >Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> >
> >On 04/29, Wan Jiabing wrote:
> >> In commit 482812d56698e ("drm/amd/display: Set max TTU on
> >> DPG enable"), "hubp.h" was added which caused the duplicate include.
> >> To be on the safe side, remove the later duplicate include.
> >>
> >> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> >> ---
> >> drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> index 8f0a13807d05..dcaa6b1e16af 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> @@ -58,7 +58,6 @@
> >> #include "dc_link_ddc.h"
> >> #include "dm_helpers.h"
> >> #include "mem_input.h"
> >> -#include "hubp.h"
> >>
> >> #include "dc_link_dp.h"
> >> #include "dc_dmub_srv.h"
> >> --
> >> 2.25.1
> >>
> >
> >--
> >Rodrigo Siqueira
> >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsiqueira.tech%2F&amp;data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Cb8ff161b3a904a49e59808d90b0991d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637552958013669698%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=I7AtEiOlzUuRQag7uAuArUvfd64l1b3gstq7ZTeucik%3D&amp;reserved=0
>
> Yours,
> Wan Jiabing
>

--
Rodrigo Siqueira
https://siqueira.tech
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-04-29 16:43    [W:0.081 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site