lkml.org 
[lkml]   [2021]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe:Re: [PATCH] drm/amd/display: Remove duplicate declaration of dc state
From
Date

>Hi Wan,
>
>Instead of remove the first dc_state, remove the second one.
>
>Thanks

Hi Rodrigo,

Thanks for your reply.

OK, in fact, there are no functions using struct dc_state between two
struct declarations. So I think removing anyone is OK.
Remove the first one to make it more closer to user.
Remove the second one more secure.
I will send v2. You can choose one of the two.

>On 04/29, Wan Jiabing wrote:
>> There are two declarations of struct dc_state here.
>> The later one is closer to its user. Remove the former duplicate.
>>
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>> ---
>> drivers/gpu/drm/amd/display/dc/dc.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
>> index 8108b82bac60..cad045db6ea2 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dc.h
>> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
>> @@ -276,8 +276,6 @@ enum surface_update_type {
>> /* Forward declaration*/
>> struct dc;
>> struct dc_plane_state;
>> -struct dc_state;
>> -
>>
>> struct dc_cap_funcs {
>> bool (*get_dcc_compression_cap)(const struct dc *dc,
>> --
>> 2.25.1
>>
>
>--
>Rodrigo Siqueira
>https://siqueira.tech

Yours,
Wan Jiabing


\
 
 \ /
  Last update: 2021-04-29 14:31    [W:0.056 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site