lkml.org 
[lkml]   [2021]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] m68k: introduce a virtual m68k machine
Hi Josh,

On Thu, Apr 29, 2021 at 1:06 AM Josh Juran <jjuran@gmail.com> wrote:
> On Apr 28, 2021, at 8:04 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > This can be simplified by shifting irq_pending instead of irq_bit:
> >
> > do {
> > if (irq_pending & 1)
> > generic_handle_irq(irq_num);
> >
> > ++irq_num;
> > irq_pending >>= 1;
> > } while (irq_pending);
> >
> > Unfortunately m68k doesn't have a single-instruction __ffs().
>
> The 68000 and 68010 don't, but couldn't the 68020's BFFFO do the job?

I looked at the code generated by gcc for __builtin_ffs(), and while
it did use BFFFO, it needs several other instructions.

The same can be seen in arch/m68k/include/asm/bitops.h:

static inline int ffs(int x)
{
int cnt;

__asm__ ("bfffo %1{#0:#0},%0"
: "=d" (cnt)
: "dm" (x & -x));
return 32 - cnt;
}


Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2021-04-29 09:25    [W:0.044 / U:1.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site