lkml.org 
[lkml]   [2021]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 1/3] dt-bindings:iio:adc: add generic settling-time-us and oversampling-ratio channel properties
On Wed, Apr 28, 2021 at 05:59:31PM +0100, Jonathan Cameron wrote:
> On Wed, 28 Apr 2021 09:32:06 +0200
> Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>
> > Settling time and over sampling is a typical challenge for different IIO ADC
> > devices. So, introduce channel specific settling-time-us and oversampling-ratio
> > properties to cover this use case.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> This and patch 2 both look good to me. Given Rob gave a minor comment on the
> previous version I don't feel I need him to look at this again.
>
> Will pick up in a few days if no other reviews come in to require a v7.

Ok, thank you!


> Thanks,
>
> Jonathan
>
> > ---
> > Documentation/devicetree/bindings/iio/adc/adc.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> > index 912a7635edc4..db348fcbb52c 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> > @@ -39,4 +39,16 @@ properties:
> > The first value specifies the positive input pin, the second
> > specifies the negative input pin.
> >
> > + settling-time-us:
> > + description:
> > + Time between enabling the channel and first stable readings.
> > +
> > + oversampling-ratio:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + Oversampling is used as replacement of or addition to the low-pass filter.
> > + In some cases, the desired filtering characteristics are a function the
> > + device design and can interact with other characteristics such as
> > + settling time.
> > +
> > additionalProperties: true
>
>
>

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

\
 
 \ /
  Last update: 2021-04-29 06:29    [W:0.064 / U:4.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site