lkml.org 
[lkml]   [2021]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 20/79] staging: media: rkvdec: fix pm_runtime_get_sync() usage count
    On Wed, Apr 28, 2021 at 04:51:41PM +0200, Mauro Carvalho Chehab wrote:
    > The pm_runtime_get_sync() internally increments the
    > dev->power.usage_count without decrementing it, even on errors.
    > Replace it by the new pm_runtime_resume_and_get(), introduced by:
    > commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
    > in order to properly decrement the usage counter and avoid memory
    > leaks.

    Again, there is no memory leak here either. Just a potential PM usage
    counter leak.

    > Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
    > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    > ---
    > drivers/staging/media/rkvdec/rkvdec.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
    > index d821661d30f3..8c17615f3a7a 100644
    > --- a/drivers/staging/media/rkvdec/rkvdec.c
    > +++ b/drivers/staging/media/rkvdec/rkvdec.c
    > @@ -658,7 +658,7 @@ static void rkvdec_device_run(void *priv)
    > if (WARN_ON(!desc))
    > return;
    >
    > - ret = pm_runtime_get_sync(rkvdec->dev);
    > + ret = pm_runtime_resume_and_get(rkvdec->dev);
    > if (ret < 0) {
    > rkvdec_job_finish_no_pm(ctx, VB2_BUF_STATE_ERROR);
    > return;

    Johan

    \
     
     \ /
      Last update: 2021-04-28 17:10    [W:3.255 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site