lkml.org 
[lkml]   [2021]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 05/79] media: i2c: video-i2c: don't resume at remove time
    Date
    Calling pm_runtime_get_sync() at driver's removal time is
    not right, as this will resume PM runtime. This is clearly
    not what it is desired there, since it calls
    pm_runtime_set_suspended() afterwards.

    So, just remove pm runtime get/put logic from the device
    removal logic.

    Fixes: 69d2a734c5dc ("media: video-i2c: support runtime PM")
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    ---
    drivers/media/i2c/video-i2c.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
    index 0465832a4090..c9a774f4c8d2 100644
    --- a/drivers/media/i2c/video-i2c.c
    +++ b/drivers/media/i2c/video-i2c.c
    @@ -893,10 +893,8 @@ static int video_i2c_remove(struct i2c_client *client)
    {
    struct video_i2c_data *data = i2c_get_clientdata(client);

    - pm_runtime_get_sync(&client->dev);
    pm_runtime_disable(&client->dev);
    pm_runtime_set_suspended(&client->dev);
    - pm_runtime_put_noidle(&client->dev);

    if (data->chip->set_power)
    data->chip->set_power(data, false);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-04-28 16:54    [W:2.457 / U:0.796 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site