lkml.org 
[lkml]   [2021]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] lib/string: sysfs_streq works case insensitively
On Mon, Apr 12, 2021 at 1:33 PM Gioh Kim <gi-oh.kim@ionos.com> wrote:
>
> As the name shows, it checks the strings inputed from sysfs.
> It should work for both case-sensitive filesystem and
> case-insensitive filesystem. Therefore sysfs_streq should work
> case-insensitively.
>
> Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
> ---
> lib/string.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/string.c b/lib/string.c
> index 7548eb715ddb..d0914dffdaae 100644
> --- a/lib/string.c
> +++ b/lib/string.c
> @@ -688,7 +688,8 @@ EXPORT_SYMBOL(strsep);
> #endif
>
> /**
> - * sysfs_streq - return true if strings are equal, modulo trailing newline
> + * sysfs_streq - return true if strings are equal case-insentively,
> + * modulo trailing newline
> * @s1: one string
> * @s2: another string
> *
> @@ -696,10 +697,11 @@ EXPORT_SYMBOL(strsep);
> * NUL and newline-then-NUL as equivalent string terminations. It's
> * geared for use with sysfs input strings, which generally terminate
> * with newlines but are compared against values without newlines.
> + * And case does not matter for the sysfs input strings comparison.
> */
> bool sysfs_streq(const char *s1, const char *s2)
> {
> - while (*s1 && *s1 == *s2) {
> + while (*s1 && tolower(*s1) == tolower(*s2)) {
> s1++;
> s2++;
> }
> --
> 2.25.1
>

Hi Andrew,

I changed sysfs_streq to be case-insensitive as you requested.
Is there any progress?

\
 
 \ /
  Last update: 2021-04-28 07:43    [W:0.068 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site