lkml.org 
[lkml]   [2021]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 076/190] Revert "net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack"
    On Wed, Apr 21, 2021 at 02:59:11PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit 20d437ee8f4899573e6ea76c06ef0206e98bccb6.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Kangjie Lu <kjlu@umn.edu>
    > Cc: Andrew Bowers <andrewx.bowers@intel.com>
    > Cc: Mukesh Ojha <mojha@codeaurora.org>
    > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/net/ethernet/intel/ixgbevf/vf.c | 5 +++--
    > 1 file changed, 3 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c
    > index bfe6dfcec4ab..501823f2d1c0 100644
    > --- a/drivers/net/ethernet/intel/ixgbevf/vf.c
    > +++ b/drivers/net/ethernet/intel/ixgbevf/vf.c
    > @@ -508,8 +508,9 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw,
    > vector_list[i++] = ixgbevf_mta_vector(hw, ha->addr);
    > }
    >
    > - return ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,
    > - IXGBE_VFMAILBOX_SIZE);
    > + ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, IXGBE_VFMAILBOX_SIZE);
    > +
    > + return 0;
    > }
    >
    > /**
    > --
    > 2.31.1
    >

    This commit is fine, I'll drop the revert.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-28 07:31    [W:4.633 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site