lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 110/190] Revert "scsi: qla4xxx: fix a potential NULL pointer dereference"
    On Wed, Apr 21, 2021 at 02:59:45PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit fba1bdd2a9a93f3e2181ec1936a3c2f6b37e7ed6.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Kangjie Lu <kjlu@umn.edu>
    > Cc: Manish Rangankar <mrangankar@marvell.com>
    > Cc: Mukesh Ojha <mojha@codeaurora.org>
    > Cc: Martin K. Petersen <martin.petersen@oracle.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/scsi/qla4xxx/ql4_os.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
    > index 7bd9a4a04ad5..5cb0dfe7a83b 100644
    > --- a/drivers/scsi/qla4xxx/ql4_os.c
    > +++ b/drivers/scsi/qla4xxx/ql4_os.c
    > @@ -3229,8 +3229,6 @@ static int qla4xxx_conn_bind(struct iscsi_cls_session *cls_session,
    > if (iscsi_conn_bind(cls_session, cls_conn, is_leading))
    > return -EINVAL;
    > ep = iscsi_lookup_endpoint(transport_fd);
    > - if (!ep)
    > - return -EINVAL;
    > conn = cls_conn->dd_data;
    > qla_conn = conn->dd_data;
    > qla_conn->qla_ep = ep->dd_data;
    > --
    > 2.31.1
    >

    Looks to be correct. Odd that you do not have to "unbind" after calling
    iscsi_conn_bind(), but hey, it's scsi functions, they are always odd :)

    I'll drop this revert.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-27 19:20    [W:2.295 / U:0.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site